Jani,
The flag chance was not intentional. I think I made that change as part of
a change to nuke empty_string() and that change to 1 was supposed to tell
REGISTER_STRINGL_CONSTANT to dup the string. My mistake and I think it
should be reverted. I confused it with the RETURN_* macros.
Andi
At 07:27 AM 5/31/2005 -0700, Andi Gutmans wrote:
Yes, the flag change was intentional in order to create an allocated empty
string.
I doubt this has anything to do with the bug report though.
At 11:04 AM 5/31/2005 +0300, Jani Taskinen wrote:
Regarding this bug: http://bugs.php.net/bug.php?id=29322&edit=1
And by looking at this commit by Andi:
http://cvs.php.net/diff.php/php-src/ext/session/session.c?r1=1.391&r2=1.392&ty=u
and this part of it:
- REGISTER_STRINGL_CONSTANT("SID", empty_string, 0, 0);
+ REGISTER_STRINGL_CONSTANT("SID", "", 0, 1);
Where flags changed from 0 to 1..
Intentional or not?
--Jani
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
