Hi,
> Dmitriy,
>
> Where did EMPTY_STR come from?
It was defined by me.
> It seems to be used in non-Unicode
> context also:
>
> Zend/zend_API.c:
> zend_error(error_type, "Method %s%s%s() cannot be a NULL
> function",
> scope ? scope->name : EMPTY_STR, scope ? "::" : "", ptr->fname);
This place doesn't need EMPTY_STR. ("" is enough)
> Besides, it generates a compile warning. Should we have this instead?
>
> #define U_EMPTY_STR ((UChar*)"\0\0")
I agree, but probably we will get warnings in other places.
Dmitry
> -Andrei
>
> On Aug 17, 2005, at 12:59 AM, Dmitry Stogov wrote:
>
> > - ZVAL_UNICODEL(delim,
> USTR_MAKE(""), sizeof("")-1, 0);
> > + ZVAL_UNICODEL(delim, EMPTY_STR,
> sizeof("")-1, 0);
>
>
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
