For those of you who submitted patches to 5.1 since RC1 - do you believe
that we need another RC or can we go ahead and roll 5.1 final and run a
sanity test for 24 hours? I went over the patches, none of them appears
to be too dangerous, but if any of you thinks differently, let me know.
Never got a clear response on whether or not that
zend_shutdown_constants(TSRMLS_C);/zend_destroy_rsrc_list(&EG(persistent_list)
TSRMLS_CC); patch (ZTS leak thread) could be committed. I realized I
might've been misleading when I said I'd "temporarily plugged that leak" I
meant in my own local checkout, not in CVS. As it's a general bug I'd
like to spread it across stable branches 4.4/5.0 and dev branches 5.1/HEAD
(with proper timing given RC cycles of course).
Index: Zend/zend.c
===================================================================
RCS file: /repository/ZendEngine2/zend.c,v
retrieving revision 1.308
diff -u -r1.308 zend.c
--- Zend/zend.c 3 Aug 2005 13:30:45 -0000 1.308
+++ Zend/zend.c 31 Aug 2005 14:39:28 -0000
@@ -486,6 +486,8 @@
static void executor_globals_dtor(zend_executor_globals *executor_globals
TSRMLS_DC)
{
zend_ini_shutdown(TSRMLS_C);
+ zend_shutdown_constants(TSRMLS_C);
+ zend_destroy_rsrc_list(&EG(persistent_list) TSRMLS_CC);
}
@@ -706,11 +708,9 @@
zend_shutdown_extensions(TSRMLS_C);
free(zend_version_info);
- zend_shutdown_constants(TSRMLS_C);
free(GLOBAL_FUNCTION_TABLE);
free(GLOBAL_CLASS_TABLE);
#ifdef ZTS
- zend_destroy_rsrc_list(&EG(persistent_list) TSRMLS_CC);
zend_hash_destroy(GLOBAL_CONSTANTS_TABLE);
free(GLOBAL_CONSTANTS_TABLE);
GLOBAL_FUNCTION_TABLE = NULL;
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
