Ah Sorry. I haven't compiled PHP on windows for some time now.
Attached is a patch thats fixes the problem.

Nuno


Latest CVS (SF anon CVS worked for me) doesn't compile with error:

ext\tidy\tidy.c(586) : error C2152: 'function' : pointers to functions
with different attributes

Edin


Nuno Lopes wrote:
answering both e-mails:

Nuno, which version of libtidy do you think we should use for bundiling
with the windows distribution?


latest CVS. It is stable ATM (but checkout with a developer account,
because sourceforge's anonymous cvs servers are currently broken).

Nuno, will this also work for 4_3 branch?


Yep, the libtidy API hasn't changed.


Nuno
Index: tidy.c
===================================================================
RCS file: /repository/php-src/ext/tidy/tidy.c,v
retrieving revision 1.66.2.7
diff -u -r1.66.2.7 tidy.c
--- tidy.c      3 Apr 2006 14:59:30 -0000       1.66.2.7
+++ tidy.c      19 Apr 2006 15:46:51 -0000
@@ -333,22 +333,22 @@
ZEND_GET_MODULE(tidy)
#endif

-void *php_tidy_malloc(size_t len)
+void* TIDY_CALL php_tidy_malloc(size_t len)
{
        return emalloc(len);
}

-void *php_tidy_realloc(void *buf, size_t len)
+void* TIDY_CALL php_tidy_realloc(void *buf, size_t len)
{
        return erealloc(buf, len);
}

-void php_tidy_free(void *buf)
+void TIDY_CALL php_tidy_free(void *buf)
{
        efree(buf);
}

-void php_tidy_panic(ctmbstr msg)
+void TIDY_CALL php_tidy_panic(ctmbstr msg)
{
        TSRMLS_FETCH();
        php_error_docref(NULL TSRMLS_CC, E_ERROR, "Could not allocate memory for 
tidy! (Reason: %s)", (char *)msg);

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to