Hi Marcus, I'm replying again for clarification about the patch. When you first replied and said it looked OK, you mentioned "once we agree to this," which I assumed meant it could be used/committed. I saw array.c hasn't been changed in CVS (though I don't know when that would happen anyway), so I was kinda wondering, that's all. :-)
Then about the tests, I still didn't know whether you'd tell me to make a tests file *after* committing the patch or if you need it *first*. Sorry. :-/ If you (meaning anyone who'd apply the patch) are just waiting for tests, please let me know, and I'll create tests for all array_fill() functionality (old and new) right away! BTW, since sending the patches, I realized that my code will allow an empty "keys" array. I'm thinking there should be a warning for that to make it consistent with the old behavior of not returning an empty array. Should I change that and RE-send patches...? Thank you, Matt ----- Original Message ----- From: "Marcus Boerger" > Hello Matt, > > in general we only require head first and once that is in we discuss > merging the stuff to older versons (in this case 5.2). Tests have not > always been required but it has shown that we introduce to many changes > this way. So we more and more develop with tests. Especially when there > is a change in an untested area it is very good to test against old > documented behavior first and then see what changes with the patch. > For the tests themselves we not test for every error situation but we > test for a lot. > > best regards > marcus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
