> fix win32 build
> EG(precision) can be changed in runtime, even in php_implode() (hint:
> __toString()), so please think twice before optimizing
>
> ...
>
> case IS_DOUBLE: {
> - char stmp[MAX_LENGTH_OF_DOUBLE + EG(precision)
> + 1];
> + char *stmp;
> + stmp = emalloc(MAX_LENGTH_OF_DOUBLE +
> EG(precision) + 1);
> str_len = sprintf(stmp, "%.*G", (int)
> EG(precision), Z_DVAL_PP(tmp));
> smart_str_appendl(&implstr, stmp, str_len);
> + efree(stmp);
>
Well as usual critizicing the commits of others but not seeing the
obvious integer overflow in memory allocation in your own commit...
Stefan
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
