Hello Sebastian, looks pretty fine. Only you don't need fallbacks right now. Simply add a check for PHP >= 5.2.0 since you are using Iterators and I don't see any sense in testing 5.0 or 5.1. You could further more make the run script operate a bit like run-tests.php and have the PHP executable be configurable and get version tested. So you would first check that the PHP runiing the run script is new enough and that second the tests are executed by an acceptable PHP version.
When you want to spend more work, ever thought of making the bench files have a layout similar to *.phpt? So that we could split up in sections like name, actual bench, clean-up, etc? Or do you prefer to do all from within one file and call bench funcs manually? best regards marcus Tuesday, February 27, 2007, 5:53:53 PM, you wrote: > Sebastian Bergmann wrote: >> Have a look at > I uploaded a snapshot of what I have now (I added fallbacks for missing > functionality in PHP 4.4 and PHP 5.0 and the rest of the benchmarks) to > http://static.phpunit.de/benchmark.tbz2. > -- > Sebastian Bergmann http://sebastian-bergmann.de/ > GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4 98CD 6277 0E5B 6867 C514 B85B 5D69 Best regards, Marcus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
