> The function call does strike me as completely unnecessary and the additional > stack operations required are expensive. I'm willing to be that if the > function was converted to a macro, the proposed solution would be a workable > fix. Just my two cents; I'm not very experienced with the PHP internals yet. > Like I said the patch was hacked in 30 minutes, to proove it is possible. I am well aware that a function call is additional overhead.
Don't forget that the MOPB-1 issue was disclosed on the 1st March. This was 2.5 months ago. 2.5 months vs. 30 minutes. Additionally the PHP dev team knows this problem for YEARS and it was the only possible solution to expose the problem during the MOPB to get it ever fixed. I am fully aware that it can be made faster. But a slow solution is better than no solution at all. Stefan Esser -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
