On Feb 11, 2008 5:55 PM, Lars Strojny <[EMAIL PROTECTED]> wrote: > Hi Pierre, > > Am Montag, den 11.02.2008, 17:42 +0100 schrieb Pierre Joye: > [...] > > Looks better :) > > Thank you! > > > I did not test it but it looks good. Did you run the tests suite? > > > > + dirname = estrndup(filename, strlen(filename)); > > + zend_dirname(dirname, strlen(dirname)); > > > > One strlen can be dropped here. > > Ah, good hint. See http://lars.schokokeks.org/php/dir-constant-5.diff > for the corrected version.
One more thing: const size_t filename_len = strlen(filename); and it should be good. Stan, looks ok for you? -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
