Even for small projects like this, we should get into the habit of creating an RFC on the Wiki.
This is a way to explain the pros & cons so the functionality can be evaluated. You can argue about the algorithm choice and point out weakness (overflow/underflow?). It allows us to see where the code will be added, and lets us see some usecases (that will become tests) etc. Chris Kalle Sommer Nielsen wrote: > Ah Cheers > > I didn't think of number optimizations, but its done now > > Cheers > Kalle > > > ----- Original Message ----- From: "Guilherme Blanco" > <[EMAIL PROTECTED]> > To: "Kalle Sommer Nielsen" <[EMAIL PROTECTED]> > Cc: "PHP Developers Mailing List" <internals@lists.php.net> > Sent: Tuesday, May 20, 2008 8:47 PM > Subject: Re: [PHP-DEV] Add deg2grad() and grad2deg() in PHP5.3 > > >> Hi... >> >> Are there any explanation why you used 360 and 400 and not optimized >> it? I know 1 full circle = 360 deg = 400 grads, but you can simplify >> it to: >> >> RETURN_DOUBLE((9 / 10) * deg); >> >> and... >> >> RETURN_DOUBLE((10 / 9) * grads); >> >> >> Regards, >> >> On Tue, May 20, 2008 at 3:22 PM, Kalle Sommer Nielsen >> <[EMAIL PROTECTED]> wrote: >>> Greetings internals >>> >>> I've made two functions that allows convertion between degress and >>> gradians, >>> below is a pastebin >>> of the functions as that would look in math.c: >>> http://www.phpfi.com/318450 >>> >>> If no objections against it I will commit them in PHP_5_3 and HEAD and I >>> will prepare some test >>> cases for those aswell. >>> >>> >>> Cheers >>> Kalle >>> >>> -- >>> PHP Internals - PHP Runtime Development Mailing List >>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >>> >> >> >> >> -- >> Guilherme Blanco - Web Developer >> CBC - Certified Bindows Consultant >> Cell Phone: +55 (16) 9166-6902 >> MSN: [EMAIL PROTECTED] >> URL: http://blog.bisna.com >> Rio de Janeiro - RJ/Brazil >> >> >> >> >> -- >> No virus found in this incoming message. >> Checked by AVG. >> Version: 7.5.524 / Virus Database: 269.23.21/1455 - Release Date: >> 19-05-2008 17:04 >> >> > > -- Christopher Jones, Oracle Email: [EMAIL PROTECTED] Tel: +1 650 506 8630 Blog: http://blogs.oracle.com/opal/ Free PHP Book: http://tinyurl.com/f8jad -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
