Hello Felipe, please do not allow non optional parameters after optional parameters. Also default value NULL seems pretty odd for a numeric type and it might be an idea to only allow types matching the type hint. But I guess it is in line the current type hints and a good solution to mark those as not passed.
You took care of reflection parameter but not of reflection method/function. What I do not like about the return type hint patch is that it adds the native types upfront. This is actually all that is discussable. Return type hints themselves were already agreed on. That said we only need to think whether your syntax is ok. And from that perspective you get my vote, too. So how about a limited patch first that does not introduce native types, only implements return type hints and does also add reflection for it. marcus Friday, April 18, 2008, 1:52:22 PM, you wrote: > Em Sex, 2008-04-18 às 10:22 +0300, Arvids Godjuks escreveu: >> +1 for strict types. >> >> That way it will be simple: >> * Don't need - then don't use at all >> * You need it - you use it fully. >> >> One thing than left to clearfy - do we allow to hint only part of args >> or do we go the road "if hint args, then hint them all!" (I'm >> personaly for second one - be strict) > No, just use in the arg that you want. > Example: > http://felipe.ath.cx/diff/tests/param_tests/param_type_hint_016.phpt > -- > Regards, > Felipe Pena. Best regards, Marcus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
