Hey Felipe,
'Scuse top-posting, my >>s have let me down again.
Two things: first, I did in ext/standard exactly as you did elsewhere (you
know this already but the rest don't). Second, I already sent the MySQL guys
some bits and pieces for their tests.
Oh, and third - if nobody gets back to us by Friday over these patches we'll
just commit :) Don't know about Felipe's larger corner, but I tested mine to
death already.
- Steph
----- Original Message -----
From: "Felipe Pena" <[EMAIL PROTECTED]>
To: "Steph Fox" <[EMAIL PROTECTED]>
Cc: "Andrei Zmievski" <[EMAIL PROTECTED]>; "internals"
<internals@lists.php.net>
Sent: Monday, June 09, 2008 7:49 PM
Subject: Re: [PHP-DEV] Re: Focus on HEAD
Hi all
Em Seg, 2008-06-09 às 18:55 +0100, Steph Fox escreveu:
Hi all,
Andrei doesn't have time to review this lot (covers ext/standard). Could
someone please check it for clangers?
Thanks,
- Steph
Here's the rest (ext/* and main/*):
http://felipe.ath.cx/diff/unicode-check.diff
- Removed:
- if (UG(unicode))
- unicode_semantics() function
- pcre_cache_entry.unicode_mode
- Changed:
- ZEND_STR_TYPE -> IS_UNICODE
- convert_to_text -> convert_to_unicode
- convert_to_text_ex -> convert_to_unicode_ex
MySQL part:
http://felipe.ath.cx/diff/mysql-unicode-check.diff
http://felipe.ath.cx/diff/mysql-tests-unicode-checks.diff
(removed the ini_set("unicode.semantics") checks)
MySQL guys, the non-unicode tests can be removed? (those that uses
SKIPIF...)
>
> Sure.
>
> Steph Fox wrote:
>>
>>> Is there a patch that does that? I'm fine with removing these checks.
>>
>> If there isn't already, there soon will be :)
>>
>> Did you want to review it prior to commit?
>>
>> - Steph
>>
>>
>
>
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
--
Regards,
Felipe Pena.
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
