now I see the main reason of the patch, but while APC is not a part of PHP yet, it might be better, easer and safer to solve its issue in APC itself (this is just a though, not a recommendation).

Anyway we need to make this patch better if we commit it, and I would ask other community members to look into it and share their opinions.

Thanks. Dmitry.

Lucas Nealan wrote:
On 8/13/08 2:10 AM, "Dmitry Stogov" <[EMAIL PROTECTED]> wrote:

I wasn't serious about removing them.

Anyway zend_alloc.c and zend_hash.c don't work with shared memory.
It's possible to reuse zend_alloc.c to allocate blocks from SHM, but
it's not its primary purpose. If APC don't do it I don't see how this
block/unblock code may protect SHM. It definitely may protect PHP from
crashes and memory corruptions during RSHUTDOWN, but only for some cases.

APC directly uses the HANDLE_BLOCK/UNBLOCK_INTERRUPTIONS macros, I assume
other extensions do this as well.

-lucas


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to