Especially for this situation warnings are generated by libxml.
I don't like to disable these warnings in ext/soap, because in some
situation libxml may generate warnings and then return parsed document.
So SoapClient() won't generate exception, but all warnings would be lost.
Thanks. Dmitry.
Lukas Kahwe Smith wrote:
>
> On 13.08.2008, at 14:31, David Zülke wrote:
>
>> True, it indeed does since 5.3... but what about that warning; does it
>> have to be raised at all? if the "exceptions" option is passed?
>>
>> Am 08.08.2008 um 09:39 schrieb Dmitry Stogov:
>>
>>> Hi,
>>>
>>> I took a quick look into the issue and I didn't found a problem.
>>> SoapClient constructor already throws exceptions in case of WSDL errors.
>>>
>>> <?php
>>> try {
>>> new SoapClient("non-existent");
>>> } catch (Exception $e) {
>>> echo "CATCHED: ".$e->getMessage()."\n";
>>> }
>>>
>>> Warning: SoapClient::SoapClient(): I/O warning : failed to load
>>> external entity "non-existent" in Command line code on line 1
>>> CATCHED: SOAP-ERROR: Parsing WSDL: Couldn't load from 'non-existent'
>>> : failed to load external entity "non-existent"
>>>
>>> SoapServer does fatal errors, but it souldn't be a problem, because
>>> servers use their own WSDL files which may be fixed.
>>>
>>> Thanks. Dmitry.
>>>
>>>
>>> Lukas Kahwe Smith wrote:
>>>> On 24.07.2008, at 14:36, Noah Fontes wrote:
>>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>>> Hash: SHA1
>>>>>
>>>>> Hi Dmitry,
>>>>>
>>>>> SOAP generally uses php_error[_docref] everywhere for errors that are
>>>>> not actual SOAP faults, even in exceptions mode. Is this intentional,
>>>>> and would it be worth the BC break to change all of the php_errors to
>>>>> exceptions?
>>>>>
>>>>> Most of the SOAP SDL-loading php_errors are also E_ERROR, for
>>>>> reasons I
>>>>> don't really understand. If we don't move to exceptions, can we at
>>>>> least
>>>>> reduce the severity for some of these to E_WARNING?
>>>>>
>>>>> e.g. (php_sdl.c:824):
>>>>>
>>>>> if (op_name == NULL) {
>>>>> soap_error0(E_ERROR, "Parsing WSDL: Missing 'name' attribute for
>>>>> <operation>");
>>>>> }
>>>> By when do you guys think you can complete the changes?
>>>> regards,
>>>> Lukas Kahwe Smith
>>>> [EMAIL PROTECTED]
>>>
>>
>
>
> Maybe a general question (not sure if its in time to address this stuff
> for 5.3.0).
>
> We are getting more and more extensions with an "exception mode". I
> guess PDO is the rolemodel here and in absence of a discussion about
> this it seems like we have accepted this sort of behavior. But what I
> wonder is if such "exception modes" should mean that if an exception is
> thrown for a specific issue, if this should then disable
> warnings/notices/errors that would be raised for the same issue.
>
> regards,
> Lukas Kahwe Smith
> [EMAIL PROTECTED]
>
>
>
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
