Hi Lukas,
(I see you CC'd Christian, but I don't think he's involved with this...)
----- Original Message -----
From: "Lukas Kahwe Smith"
Sent: Saturday, April 04, 2009
On 31.03.2009, at 00:32, Lukas Kahwe Smith wrote:
On 31.03.2009, at 00:27, Pierre Joye wrote:
On Tue, Mar 31, 2009 at 12:09 AM, Lukas Kahwe Smith <m...@pooteeweet.org
> wrote:
Hi guys,
Just wanted to know if those issues are resolved?
I rather not have a flow of changes in this area just before the next
RC2.
As a matter of fact this is the main thing that needs to get done
before
RC2.
Other things are listed here:
http://wiki.php.net/todo/php53#rc2
I would not mind being able to release RC Thursday next week. Which
would
mean commit freeze starting Monday next week. So how are things
looking?
No chance from my side to get a commit freeze on next Monday. It is
way too short sorry.
Ok, then I would appreciate estimates for each item that cannot be
completed until then.
As soon as you can give them ...
So nobody is able to give me any feedback, so that we can plan RC2? I
must say this is kind of irritating, but so it goes.
Sorry if I was irritating (in addition to my noise about this number stuff).
:-) When you sent the first message of this thread last week, I was just
starting to look at changing the conversion to something I'd be more
satisfied with than the patch I sent. So I was waiting to see what to
report before replying. Then Thursday I replied to Dmitry with some of
those details, instead of replying to you... Then I was going to reply to
this last message, asking for feedback, a few hours after you sent it, but
didn't get time. Glad I didn't though (not to irritate you more, ha),
because yesterday after testing things further with my more "more complete
and precise" conversion method, I'm thinking differently after noting
behavior patterns -- on Windows and [firsts for me] 32- and 64-bit Linux.
(Probably a good thing, because what I had, while only 70-ish lines (with
duplication) looked like overkill, with more "magic" than Dmitry commented
on with the other version!)
So, whether that made any sense to anyone, what does this mean? Well, now I
think the best proposal will be to use the same conversion as 5.2 and
earlier, with only a small change to address the issue Zoe reported in Bug
#42868, which caused the 5.3 change. This would keep/restore the old
overflow behavior that *most people have always been getting with PHP* by
having conversion behave the same on a platform where 5.2 didn't work the
"usual" way -- like the Mac in Zoe's report. It's very simple and would
look almost exactly like 5.2's code. :-) Since nobody has tried to define
what exactly the behavior should be, after analyzing everything I can
gather, I think it's a good, simple solution to keep things consistent,
within the limitations I've observed across platforms...
Still thinking about one thing, but I'll send an updated patch in a day or
two I guess.
Oh, other than that about the RC2 subject, I was also going to propose some
scanner changes like I mentioned to Brian on the 26th. Assuming it works
like in my head, it would basically be a big "diet" for the scanner, making
string/comment handling smaller and simpler, while addressing the cause (for
strings/comments at least) of Bug #46817 (tokenizer misses last single-line
comment) which is wrongly marked Closed and DONE on the wiki. Before RC1,
Brian reverted his changes that, I guess, had fixed it.
regards,
Lukas Kahwe Smith
m...@pooteeweet.org
- Matt
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
