Howdy,

In response to Bug #48911(http://bugs.php.net/bug.php?id=48911), revision 
286468 adds SAPI_API to

   int php_embed_init(int argc, char **argv PTSRMLS_DC);
   void php_embed_shutdown(TSRMLS_D);
   extern sapi_module_struct php_embed_module;

Which breaks building the php5embed on Windows.

On Windows, php5embed is built as a static library, and doesn't need these 
functions to be marked as SAPI_API.

Can I suggest we instead use "EMBED_SAPI_API" and insert :

   #ifndef PHP_WIN32
       #define EMBED_SAPI_API SAPI_API
   #else
       #define EMBED_SAPI_API
   #endif

Garrett


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to