On Mon, 15 Nov 2010, Rasmus Lerdorf wrote:
> Ok, I went through all the 5.3 code. This should fix the null poisoning
> problems in 5.3 without breaking binary compatibility:
>
> http://progphp.com/nullpatch.txt
>
> There are quite a few places where we can't solve it centrally, so
> perhaps we need to take the same approach in trunk.
I've had a look at that patch, and it looks a little bit like a kludge.
I'm saying that because it's quite easy to miss a specific case where a
line like:
+ if (strlen(filename) != filename_len) {
+ RETURN_FALSE;
+ }
should/could be added. I prefer a fix that solves this properly, and
that requires breaking BC as I understood it. Perhaps we could just take
care of this in trunk only? Or at last, add a macro for doing the check
from above?
cheers,
Derick
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
