On Tue, 2011-01-25 at 19:09 +0100, Keisial wrote: > This thread went on bikeshedding about if it's legal C or not.
The question whether the code is legal or not is not bikeshedding. Valid, correct, code is important. Both for function and for maintenance. The questions is cleared: The old code is fully valid. So the question which style is preferred is indeed a bikeshed question. On the other side there seem to be validators having trouble with this code. That makes one wonder how valid the results are when a simple expression like the one discussed here already causes trouble and whether it is worth to risk issues introduced by these changes (and we saw they easily accidentally cause issues) ... I think a good way would be to move this change to a branch, run the analyzer and if there are useful results decide on their benefit vs the change risk. johannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
