On Mar 11 23:22:04, Sebastian Marek wrote: > Hi, > > I have recently used SplFileObject to work with files. I was lacking a bit > of functionality in there regarding counting number of lines in a given > file. Although I could just load contents of the file to an array and check > it size, I thought it would be nice to have SplFileObject Countable. > > Here is an example implementation I made tonight that seems to work well - > https://gist.github.com/866767 . Is it something you think would be worth > adding to the existing SplFileObject? Is the implementation any good? I > reused some of the existing logic to avoid breaking 'spl_filesystem_object' > internal integrity, but maybe it would make sense to make it work with the > stream itself.
In my oppinion, it does not make sense to implement countable for this use. Countable should be implemented on classes where calling count() on them is not ambiguous, i.e. the size of a collection. There is no reason why count() on a file should be the number of lines, why not words, or bytes? I'd however be happy with a new countLines() method. Best, > > If it's fine I can write some unit tests to cover this and then submit a > complete patch. > > Regards > -- > Sebastian Marek > proo...@gmail.com > > Follow me online at: > Blog: http://criticallog.thornet.net/ > Twitter: http://twitter.com/proofek > Linkedin: http://uk.linkedin.com/in/sebastianmarek > Ohloh: http://www.ohloh.net/accounts/proofek > <http://twitter.com/proofek> -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
