On Thu, Jun 23, 2011 at 11:28 PM, Stas Malyshev <smalys...@sugarcrm.com>wrote:
> Hi! > > > On 6/23/11 12:47 PM, Derick Rethans wrote: > >> I'd like to revert this change *and* change when the docrefs are >> shown, so that in 5.4 and trunk: >> - html_errors is on by default again. >> - the docref links are only shown when docref_root is not empty >> >> A patch is attached. Comments? >> > > Thinking more about this: if we're in production, that means display_errors > is off. So where exactly we expect to have these HTML errors and how they > are useful? > > I have no idea why specific settings of xdebug depend on html_errors and > why xdebug can't have its own configuration setting to fix it if needed - > but this has nothing to do with PHP defaults IMO. I'd like to hear and > explanation how production setting of html_errors as 1 is useful. > > xdebug does some fancy html around the output of the stack trace/var_dump calls, and it only does that if html_errors is enabled. usually you don't use xdebug in production, so it really doesn't matter much. but because we suggest in the production ini that it has a performance and security impact, distros ships with html_errors turned off, which prevents xdebug from enhancing the output. I think that this could be changed back how it was before, but if many of you think that this is a bad idea, then probably Derick should stop using this config option for controlling this particular feature in xdebug, and he could introduce a new option. Tyrael
