Hi Reindl: On Sun, Aug 21, 2011 at 03:08:09PM +0200, Reindl Harald wrote: > This is my try to help badly prevent broken releases like > 5.3.7 in the future, 54 failing tests are way too much and > the XFAILED should be removed until they are working
XFAIL's should stay, in my opinion. Their results go to the "EXPECTED FAILED TEST SUMMARY" so there's no confusion with stuff in the "FAILED TEST SUMMARY." > FAIL DateTime::diff() days -- spring type2 type2 > [ext/date/tests/DateTime_days-spring-type2-type2.phpt] > FAIL DateTime::diff() days -- spring type2 type3 > [ext/date/tests/DateTime_days-spring-type2-type3.phpt] > FAIL DateTime::diff() days -- spring type3 type2 > [ext/date/tests/DateTime_days-spring-type3-type2.phpt] > FAIL DateTime::diff() days -- spring type3 type3 > [ext/date/tests/DateTime_days-spring-type3-type3.phpt] > FAIL DateTime::sub() -- dates [ext/date/tests/DateTime_sub-dates.phpt] > FAIL DateTime::sub() -- february [ext/date/tests/DateTime_sub-february.phpt] That's weird. Those are marked for XFAIL. How were you running the tests and on what checkout/code base? Also, it looks like you're reading from the main output list, not the various SUMMARY sections, which is totally inefficient because it lists passes, skips, etc, too. Thanks, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y data intensive web and database programming http://www.AnalysisAndSolutions.com/ 4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php