Hi all, On Tue, Aug 23, 2011 at 04:33, Daniel Convissor <dani...@analysisandsolutions.com> wrote: > Hi Stas: > > On Mon, Aug 22, 2011 at 03:31:56PM -0700, Stas Malyshev wrote: >> >> We still have tons of failures in DateTime IIRC and that's because >> of the buggy three-letter timezones. > > There are bugs with both type 1 (regularly created datetimes) and type 2 > (datetimes created using three letter timezones) timezone objects when > it comes to the daylight/standard time transition. I've composed a > first draft of an RFC on how PHP should behave regarding these > transitions and am refining it with Derick. I hope it will be finished > soon. Once that's done, the code can be fixed to match the expected > behavior. > > >> not fixed - would be great if we could have it for 5.4 release. >> Derick? > > Yes, it would be great for this to be in 5.4.
I probably don't know enough about procedures here. But if you know that the tests are failing, you should move them to XFAIL category, don't you? So if there is a test which falls into the FAILED, you can stop the build and investigate what went wrong. This will also allow you to do automated tests on nightly builds and make the tests mandatory before the release by enforcing the policy by some release scripts. Or make the tests mandatory on every build with option to turn them (selectively) off. I will also try to automate this process in the Debian packages (saving list of failed tests somewhere and comparing them to the results of the build). But that doesn't mean the results will be same as vanilla PHP (embedded vs shared libraries, some Debian specific patches, etc.) and same on different systems with different libraries. O. -- Ondřej Surý <ond...@sury.org> -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
