2011/12/24 Johannes Schlüter <johan...@schlueters.de>: > On Sat, 2011-12-24 at 11:56 +0000, Derick Rethans wrote: >> On Sat, 24 Dec 2011, Pierre Joye wrote: >> >> > Laruence refers to the PHP C source code and removing trailing white >> > spaces is a good thing as it is part of our CS. >> > >> > Go ahead Laruence :) >> >> Please don't. Changing whitespace en-masse makes it a royal pain to do >> merges later. Please just fix them when you change the code on that line >> only. > > It's not only bad for merges, also confusing with blame/annotate while > identifying the reason for bug. > hmm, yes, you are right :),
actually, I am not saying that I am going to do such behavior, just remind us that we should watch such CS, since there have been lots of tail ws now... :) thanks > johannes > >> Derick >> >> -- >> http://derickrethans.nl | http://xdebug.org >> Like Xdebug? Consider a donation: http://xdebug.org/donate.php >> twitter: @derickr and @xdebug >> > > -- Laruence Xinchen Hui http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
