On Sun, Feb 5, 2012 at 5:23 PM, Rasmus Lerdorf <ras...@lerdorf.com> wrote:
> On 02/05/2012 02:49 AM, Ferenc Kovacs wrote: > > Hi Rasmus, > > > > I see that you are fixing tests in the 5.4 branch, however I was told by > > Stas that I should hold my test fixes until the release: > > http://www.mail-archive.com/internals@lists.php.net/msg55515.html > > I would think that fixing failing tests should be ok even this late in > > the release process. > > Worst case scenario somebody borks a test or two. > > Hrm, I didn't notice that request to hold test fixes as well. I have > been going through the reported test failures from people sending them > in from the 5.4 RCs and fixing the obvious ones that I can reproduce > myself. I don't think fixing test cases is a destabilizing action, even > if we completely mess up a test, that has already been reported as > failing by many people, we are no worse off than before. > > -Rasmus > yeah, same opinion here. ps: I forgot to cc the list in my first email, I've done it now. -- Ferenc Kovács @Tyr43l - http://tyrael.hu
