On Wed, Jun 6, 2012 at 4:29 AM, Felipe Pena <felipe...@gmail.com> wrote:
> Hi, > > 2012/6/6 Pierre Joye <pierre....@gmail.com>: > > hi, > > > > Pull it but I would still do a RFC to clearly document it (exact > > behaviors), which could be then used by the doc team and to implement > > tests. > > > > On Wed, Jun 6, 2012 at 11:51 AM, Derick Rethans <der...@php.net> wrote: > >> David Soria Parra <d...@php.net> wrote: > >> > >>> Going through the 26 open pull requests (please let us work on getting > >>> that number down), I stumbled over > >>> https://github.com/php/php-src/pull/60. > >>> > >>> This was already proposed on the mailinglits, but the thread died fast > >>> without > >>> a satisfying answer on whether to add a function boolval() or not. > >>> > >>> Personally I would like to see the function in. Having a complete set > >>> of XYZval() functions is a good reason for me to add that function. > >>> The > >>> implementation is simple and straight forward and easy to maintain. > >>> > >>> Do we need an RFC for that simple pull request or can we just go ahead > >>> and pull it? > >> Pull it. > >> > >> Derick > >> > >> -- > >> PHP Internals - PHP Runtime Development Mailing List > >> To unsubscribe, visit: http://www.php.net/unsub.php > >> > > > > > > Pull it! About the RFC, I think isn't necessary as the behavior is > obvious, i.e. it behaves like a cast to bool. > > -- > Regards, > Felipe Pena > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > IMHO since it represents a language change (albeit a minor one) I agree with Pierre that an RFC wouldn't hurt. If nothing else it's just a good habit to get into I think. --Kris
