On Wed, 2012-07-11 at 20:39 -0400, Anthony Ferrara wrote: > Johannes, > > One thing to keep in mind when doing this is to think about consistency. > > > > I think that's a huge point not to be taken lightly. For that reason, I > think that this API should not be used for any of the array_* functions. > Meaning that array_sum(), etc should all take arrays only. > > Then, other non-array functions (such as str_replace, etc) can be modified > to use this new method.
Not sure that's more consistent then. For having a _quick_ guess on how many functions might be affected, roughly, I did a simple grep: $ grep -cE 'zend_parse_parameters(_ex)?[^"]*"[^"]*[aAhH][^"]*"' \ ext/*/*.c Zend/zend_builtin_functions.c | grep -v :0 ext/curl/interface.c:1 ext/date/php_date.c:2 ext/dom/xpath.c:1 ext/filter/filter.c:1 ext/gd/gd.c:5 ext/iconv/iconv.c:1 ext/imap/php_imap.c:2 ext/ldap/ldap.c:2 ext/mysqli/mysqli_embedded.c:1 ext/mysqli/mysqli_nonapi.c:1 ext/odbc/php_odbc.c:1 ext/openssl/openssl.c:12 ext/pcntl/pcntl.c:4 ext/pcre/php_pcre.c:1 ext/pdo_pgsql/pgsql_driver.c:1 ext/pdo/pdo_dbh.c:2 ext/pdo/pdo_stmt.c:2 ext/pgsql/pgsql.c:11 ext/phar/phar_object.c:2 ext/reflection/php_reflection.c:3 ext/soap/soap.c:3 ext/sockets/sockets.c:1 ext/spl/spl_directory.c:1 ext/spl/spl_fixedarray.c:1 ext/spl/spl_iterators.c:1 ext/standard/array.c:43 ext/standard/basic_functions.c:4 ext/standard/file.c:1 ext/standard/proc_open.c:1 ext/standard/streamsfuncs.c:5 ext/sysvmsg/sysvmsg.c:1 ext/xmlrpc/xmlrpc-epi-php.c:4 ext/xsl/xsltprocessor.c:2 ext/zip/php_zip.c:2 In total 126 matches. Now somebody has to go quickly over them ;-) johannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
