Hi!

> You had less complex patch posted on #35050 bug report for the last four
> years.

That patch, unfortunately, is not correct since it assumes every
function using tolower wants ASCII tolower. This makes, for example,
substr_compare() ignore locale, and probably a bunch of other functions.
Which is probably not a desired effect.

> Code already uses (or used when I was looking at that code) locale
> insensitive tolower version on Windows. Why you insist on using locale
> sensitive function on other platforms.

I don't know when you looked at the code, but right now for windows the
following is used:

#define zend_tolower(c) _tolower_l(c, current_locale)

As specified in http://msdn.microsoft.com/en-us/library/8h19t214.aspx,
this is definitely locale sensitive function.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227



-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to