On Thu, Mar 14, 2013 at 4:32 PM, Anatol Belski <a...@php.net> wrote:

>> One doubt I have yet after investigating on #62852 is that issuing
>> php_error isn't recoverable, it might be much better to throw exception in
>>  __wakeup(), just like __construct() does. This question crosses both
>> #62852  and #53437. That would work for 5.5 as unserialize() cares about
>> exceptions in __wakeup(), in 5.4 and less php_error seems to be a better
>> way. What do you think?
> I've reuploaded the patch, removed that extra checks, fixed the relevant
> tests, removed XFAIL from bug53437.phpt and added three more.
> https://bugs.php.net/patch-display.php?bug_id=53437&patch=date_patch_var4.patch&revision=latest

Tests pass, crashes are gone and the patch meets the requirements
Derick asked earlier. If there is no further objection until next
Monday I will ask Anatolyi to apply it and finally fix one of the only
remaining known crash in 5.3/4, and indeed 5.5 and master (but there
are other there :).



PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to