At a glance, this looks awesome. There are a few changes where you introduced #ifdef WIN32 checks that I want to spend a little more time looking at...
-Sara P.S. - Could I convince you to put it on a github fork to make it easier to read? No big deal if not... I just like that web view. :) On Mon, Jul 29, 2013 at 3:01 AM, Andrey Hristov <p...@hristov.com> wrote: > Hi, > after experiencing again warnings about conversion from const char * to > char * when calling some PHP API functions I decided to spend some time and > constify a few of these. The result is a patch that constifies the Streams > API, and few functions in Zend and TSRM (to which I have no karma). Most of > the changes are conversion of "char *" to "const char *" parameters, where > applicable. In a few places string lengths are changed from int to size_t. > Few functions return now "const char *" instead of "char *" (the caller did > not modify/release these before). > > The patch is against php-src because it changes API which can be only done > in a new version. > > Opinions? > > Best, > Andrey > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >
