On Fri, Jul 25, 2014 at 4:36 PM, Ferenc Kovacs <tyr...@gmail.com> wrote:
> > > > On Wed, Jul 23, 2014 at 10:45 PM, Bob Weinand <bobw...@hotmail.com> wrote: > >> Am 23.7.2014 um 22:33 schrieb Stas Malyshev <smalys...@sugarcrm.com>: >> > Hi! >> > >> >> It was a restriction to not support arrays in constant context. It >> seems >> >> like nobody can remember why it was introduced. >> > >> > My vague recollection is that it had some troubles with keeping >> > refcounts consistent, esp. withing bytecode caching context, but it may >> > be a false memory :) >> >> That doesn't really make much sense to me, at least not with current >> engine... >> As said, I've tested it and didn't find issues. Maybe I just test the >> wrong things… >> >> >> However, I think it's too dangerous to break it in last minute before >> >> release. >> > >> > We definitely need to fix the WTF with "no runtime use" for defined >> > constant and the segfault before the release. I think for the arrays, if >> > we can't have it working properly we'd better not have array support >> > there for 5.6.0 and fix it in 5.6.1 than have this weird "no runtime >> > use" thing. >> >> Well, we still could fix it now, AFAIK, we will still have another RC now >> and when we fix it only for 5.6.1, there also will only be one RC in >> between. >> That's no gain in testing time etc.. >> >> Bob >> >> > -- >> > Stanislav Malyshev, Software Architect >> > SugarCRM: http://www.sugarcrm.com/ >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > yeah, there will be another RC for sure, but we have to have some > resulotion for that. > I think it would be safer to remove stuff (even if just the array support) > than trying to fix in in a hurry, as it would probably just cause shipping > the final with some other bug(s) or having a couple of other RCs. > nevermind, I've somehow missed https://github.com/php/php-src/commit/c49a06168ed3759779452e2b2a44da22e75a0702 and https://github.com/php/php-src/commit/d909b6330e314bb434350317fda5bec185ea12c0 -- Ferenc Kovács @Tyr43l - http://tyrael.hu
