Hi Kevin, On Wed, Nov 12, 2014 at 4:09 PM, Kévin Dunglas <dung...@gmail.com> wrote:
> I'll change my PR according to the RFC I've quoted earlier: > - check for valid characters (excluding underscore) only when > FILTER_FLAG_HOSTNAME is set > - allow any character but check lengths by default > - use FILTER_FLAG_HOSTNAME to validate URLs > > What do you think about that? > I haven't read diff closely, but it seems ok to me. How email domain is checked? I cannot see changes for it from the diff. Validating host correctly is difficult, I would like to have your PR. Regards, -- Yasuo Ohgaki yohg...@ohgaki.net
