Hi Rasmus, Thanks for the highlight. My biggest concern about all this breakage done for NG could somehow be minimized by providing possible alternate implementations that could work both backwards compatible and forwards compatible? I just don't want to work on extensions I support that would never be usable in earlier versions once finished the update.
Maybe it would be interesting to have samples of before/after (like you did) and also samples of of compatibility pieces for PHP 7- and PHP 7+. Regards, On Thu, Feb 5, 2015 at 5:28 PM, Rasmus Lerdorf <ras...@lerdorf.com> wrote: > We have had quite a number of changes to the extension API and it > worries me a little bit how long it will take everyone to get their > extensions ported. We have UPGRADING.INTERNALS which still needs some > love, but even if that covered everything it is sometimes hard to match > a bullet point in a long list of changes to actual code. > > Having just finished porting php-memcached (with help from Xinchen) to > PHP7 I was wondering if it wouldn't be worthwhile to annotate the diff > and explain why each change was made. The extension is complicated > enough to cover most of the changes the bulk of extension authors need > to worry about. > > The diff is easy enough to grab: > > git clone https://github.com/php-memcached-dev/php-memcached.git > cd php-memcached > git checkout php7 > git diff master php7 > > It looks like this: > > https://gist.github.com/anonymous/15cbc9947edb4f0a71fd > > Any suggestions for how to handle annotating it? We could turn it into a > fake PR and mark it up using github's PR comments. But is there > something more suited for this out there? > > -Rasmus > > -- Guilherme Blanco MSN: guilhermebla...@hotmail.com GTalk: guilhermeblanco Toronto - ON/Canada
