Hi, 2015-03-11 11:49 GMT-03:00 Nikita Popov <nikita....@gmail.com>:
> On Mon, Mar 9, 2015 at 6:47 AM, Marcio Almada <marcio.w...@gmail.com> > wrote: > >> Hi, >> >> Just passing by to announce I already have a working version of the new >> patch: https://github.com/php/php-src/pull/1158 >> >> The patch is 100% compatible with the proposed one with the advantages: >> >> - Has no regression or forward compatibility risks and is highly >> predictable >> - Has an very small footprint compared to the previous attempt >> involving >> a pure lexical approach >> - Is highly configurable, to make a word semi-reserved you only have to >> edit a single inclusive list in a parser rule. >> - Requires a single compile time check >> >> More than ever, I'd like to advice voters to vote for the feature as the >> new implementation is already on it's way. There still some work to be >> done, please refer to the task list on the pull request to see what still >> needs to be done. >> >> It would be nice to have the new patch reviewed too. >> > > The new implementation does indeed look much nicer :) The only open > question left is how you want to deal with ext/tokenizer support. Can you > clarify your plan regarding that? > I'm working right now to add full support to ext tokenizer back. I'm not very experienced with the PHP implementation so, needless to say, I found numerous ways to break the tokenizer extension \o/ But a solution is getting closer and might get pushed soon. If some harder problem I don't have enough information to solve arise I'll try to ask for some advice or collaboration, though it doesn't seem necessary for now as we still have some time and it's been a great learning experience :) > > Also, is this vote about the new implementation now? > > I'm updating the RFC (rush time here gimme a few minutes) to list both implementations side by side on the patch section, and explaining that the second patch supersedes the first one. > Nikita > > Márcio
