it is not weird as we still send the tgz not the tar. try this: https://gist.github.com/pierrejoye/c33338677f89159f696d
I cannot test and crafted it a la volee, but it should do it: $file is used to query the file from the database, which contains only filenames with tgz (as we created the .tar manually now) $basename is what is used by X-SendFile, this patch fixes it and create <release>.tar instead of <release>.tgz On Fri, Apr 17, 2015 at 1:26 AM, Ferenc Kovacs <tyr...@gmail.com> wrote: > > > On Thu, Apr 16, 2015 at 8:18 PM, Hannes Magnusson > <hannes.magnus...@gmail.com> wrote: >> >> On Thu, Apr 16, 2015 at 11:06 AM, Ferenc Kovacs <tyr...@gmail.com> wrote: >> > >> > >> > On Thu, Apr 16, 2015 at 8:02 PM, Ferenc Kovacs <tyr...@gmail.com> wrote: >> >> >> >> >> >> >> >> On Thu, Apr 16, 2015 at 7:43 PM, Hannes Magnusson >> >> <hannes.magnus...@gmail.com> wrote: >> >>> >> >>> On Thu, Apr 16, 2015 at 10:14 AM, Ferenc Kovacs <tyr...@gmail.com> >> >>> wrote: >> >>> > >> >>> > >> >>> > On Thu, Apr 16, 2015 at 5:29 PM, Pierre Joye <pierre....@gmail.com> >> >>> > wrote: >> >>> >> >> >>> >> On Thu, Apr 16, 2015 at 10:02 PM, Ferenc Kovacs <tyr...@gmail.com> >> >>> >> wrote: >> >>> >> > >> >>> >> > >> >>> >> >> >> >>> >> >> As of the uncompressed data, I see something like less 0.01% of >> >>> >> >> the >> >>> >> >> requests actually requesting non compressed archives, the box he >> >>> >> >> uses >> >>> >> >> must on of the 3-4. We are in the 21st century and compressed >> >>> >> >> output >> >>> >> >> is quite a standard. It makes the server serves faster too as we >> >>> >> >> rely >> >>> >> >> on X-SendFile, as I reportedly said on this list during the >> >>> >> >> migration, >> >>> >> >> and ask for tests. >> >>> >> > >> >>> >> > >> >>> >> > hi Pierre, >> >>> >> > >> >>> >> > where do you get this 0.01%? >> >>> >> > from a quick look: >> >>> >> > root@pecl:~# grep '.tar.gz ' >> >>> >> > /var/log/apache2/pecl.php.net-access.log|wc >> >>> >> > -l >> >>> >> > 242 >> >>> >> > root@pecl:~# grep '.tar ' >> >>> >> > /var/log/apache2/pecl.php.net-access.log|wc -l >> >>> >> > 1350 >> >>> >> > so the majority of the download requests are looking for the >> >>> >> > uncompressed >> >>> >> > tar file, which is doesn't work now thanks to your changes. >> >>> >> > is there another metric or something that I'm missing? >> >>> >> > it seems that this is something which we should fix/restore even >> >>> >> > if >> >>> >> > it >> >>> >> > costs >> >>> >> > us a bit more cpu. >> >>> >> >> >>> >> I check with the whole old log, was low. >> >>> >> >> >>> >> No need to change the download code. >> >>> >> >> >>> >> I will run a script to store both tgz and tar, easier and better. >> >>> >> And >> >>> >> changing the release code to save the uncompressed archive as well. >> >>> >> Way better than what we had before. And if we like to be the only >> >>> >> one >> >>> >> to provide uncompressed download of our releases, why not, I do not >> >>> >> mind much ;-) >> >>> >> >> >>> >> But that's actually not a bug as of now, the SSL thing Hannes was >> >>> >> experiencing is what I was asking for, it is what I wonder what >> >>> >> happened to get the installer requesting SSL: in the 1st place and >> >>> >> how >> >>> >> it ends up like that and failed. But Hannes seems to do not care, >> >>> >> so I >> >>> >> will simply enable SSL again and that should be it. >> >>> >> >> >>> >> Cheers, >> >>> >> -- >> >>> >> Pierre >> >>> >> >> >>> >> @pierrejoye | http://www.libgd.org >> >>> > >> >>> > >> >>> > >> >>> > ok, after discussing with Pierre I gunzipped the release tarballs so >> >>> > now >> >>> > they are there, Pierre will update the release upload/delete code so >> >>> > that we >> >>> > also store/delete the .tar files so they can be also served via >> >>> > sendfile. >> >>> >> >>> $ sudo pecl install memcached >> >>> Could not download from "http://pecl.php.net/get/memcached-2.2.0.tar";, >> >>> cannot download "pecl/memcached" (File >> >>> http://pecl.php.net:80/get/memcached-2.2.0.tar not valid (received: >> >>> HTTP/1.0 404 Not Found >> >>> )) >> >>> Error: cannot download "pecl/memcached" >> >>> Download failed >> >>> install failed >> >> >> >> >> >> it seems that the two commits (reverts) which should make that error go >> >> away still not make to the peclweb machine yet. >> >> I will wait an hour or so, if still not there I will check out the >> >> rsync >> >> box (as I verified that the update-peclweb is executed properly). >> >> >> >> -- >> >> Ferenc Kovács >> >> @Tyr43l - http://tyrael.hu >> > >> > >> > >> > oops, I made a mistake, one of the two reverts was against the wrong >> > hash. >> > just fixed it now. >> >> >> >> Getting closer :) >> >> $ sudo pecl install memcached >> downloading memcached-2.2.0.tar ... >> Starting to download memcached-2.2.0.tar (70,449 bytes) >> .....done: 70,449 bytes >> could not extract the package.xml file from >> "/tmp/pear/download/memcached-2.2.0.tar" >> Download of "pecl/memcached" succeeded, but it is not a valid package >> archive >> Error: cannot download "pecl/memcached" >> Download failed >> install failed >> $ file /tmp/pear/download/memcached-2.2.0.tar >> /tmp/pear/download/memcached-2.2.0.tar: gzip compressed data, from >> Unix, max compression >> >> >> It looks like it is actually gzipped? >> >> -Hannes > > > hm, weird, created it via gunzip -c ing the tgz, so it should be a tar file: > root@pecl:~# file /var/lib/pear/memcached-2.2.0.tar > /var/lib/pear/memcached-2.2.0.tar: POSIX tar archive (GNU) > > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu -- Pierre @pierrejoye | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
