We should NOT use it everywhere. It'll lead to code bloat. Thanks. Dmitry.
On Wed, Jun 24, 2015 at 12:21 PM, Ferenc Kovacs <tyr...@gmail.com> wrote: > On Wed, Jun 24, 2015 at 3:42 AM, Yasuo Ohgaki <yohg...@ohgaki.net> wrote: > > > Hi all, > > > > I'm wondering the state of Fast ZPP. > > https://wiki.php.net/rfc/fast_zpp > > > > Last year's Dmirty's commit message say, it should > > only applied to most used functions due to the state of > > Fast ZPP. > > > > commit 27f38798a1963de1c60aae4ef8a3675138255574 > > Author: Dmitry Stogov <dmi...@zend.com> > > Date: Fri Jul 11 16:32:20 2014 +0400 > > > > Fast parameter parsing API > > > > This API is experimental. It may be changed or removed. > > It should be used only for really often used functions. > > (Keep the original parsing code and wrap usage with #ifndef FAST_ZPP) > > > > > > Are we supposed to convert anything to Fast ZPP now? > > What about the #ifndef FAST_ZPP? Is this required now? > > > > BTW, if we are supposed to use only Fast ZPP, > > https://github.com/php/php-src/blob/master/README.PARAMETER_PARSING_API > > should be updated. > > > > Regards, > > > > -- > > Yasuo Ohgaki > > yohg...@ohgaki.net > > > > it was meant as a performance optimization for the most heavy/hot > codepaths. > What gave you the idea that the situation changed and we should use it > everywhere? > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu >
