Hi Matt,
Matt Wilmas wrote:
Hi Bob, all,
After this commit:
http://git.php.net/?p=php-src.git;a=commitdiff;h=509712c7d9056b4ceb50134bfeea1a1115720744
In streamsfuncs.c, line 996 has an extra comma; and line 1511 has #ifdef
instead of #ifndef ...
BTW, maybe with the changes I'll propose, all this extra FAST_ZPP stuff
can be cleaned up, for 7.1 at least.
Is it worth keeping these FAST_ZPP #ifdefs around, still? FAST_ZPP is
probably here to stay, and what was the core (not the entirety) of
FAST_ZPP is now always built regardless of whether the macro is defined,
because it shares parameter-handling code with zend_parse_parameters and
scalar type declarations.
One problem with keeping the #ifdefs is that the FAST_ZPP and
zend_parse_parameters versions of argument handling can and do go out of
sync. Also, I don't think it's even an actual compile-time option to
disable FAST_ZPP anyway. You have to modify the source code and comment
out the #define.
So, would there be any objection to getting rid of the #else branches in
such #ifdefs?
Thanks!
--
Andrea Faulds
http://ajf.me/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
