On Feb 25, 2016 2:08 PM, "Dmitry Stogov" <dmi...@zend.com> wrote: > > > > > ________________________________ > From: Dmitry Stogov > Sent: Wednesday, February 24, 2016 13:35 > To: Hynek Bartoš; php-...@lists.php.net; php-general-h...@lists.php.net > Subject: Re: unpack() > > > Hi, > > > I think the requested feature may be really useful. > > And the implementation is really simple https://gist.github.com/dstogov/edbb1efcd1e9701e75ab > > I think, committing this into master doesn't require RFC and voting. > > Anyone objects?
Fine with me. Thanks for stepping in! I even missed the original mail :) > > Thanks. Dmitry. > > > ________________________________ > From: Hynek Bartoš <hbar...@gmail.com> > Sent: Wednesday, February 24, 2016 01:59 > To: php-...@lists.php.net; php-general-h...@lists.php.net > Subject: unpack() > > Dear PHP developers, > Over more than 10 years, I'm missing optional 3rd argument, > an $offset argument, in function unpack(): > > array unpack (string $format, string $data, int $offset = 0) > > The reason is very simple... Every time I need to use this > function to convert some binary data I must seek to correct > place, usually by cutting some piece with substr() function. > Sometimes I don't know how many bytes ASCII-Z strings will > consume, so I must cut larger strings which waste resources > like CPU time and memory... > > During first five years I hoped that at least every second > user of this function will need the same feature and some > improvement will be very soon available. But as time passed > I decide to write you some notes. > > I don't know which discussion group was it and as I checked > my email, no responses indicating any comments was found > since 2009 when I posted my suggestions. :-( > > Because I'm not in any mail group, Twitter, IRC nor other > talk space any more, I'm writing you to published addresses > with hope you would forward it to the right place... > > I'm confident that this improvement is very simple update > in the C code and will save lots of troubles to many people > which are using this cool function. > > Best regards, Hynek Bartos, Europe, Prague. >
