Great it's not used anymore [😊] I personally agree to remove this.
Nikita, can you also investigate the need for double pointer to object in typedef union _zend_function *(*zend_object_get_method_t)(zend_object **object, zend_string *method, const zval *key); As I remember, it's necessary only for some SPL hack, and looks like a terrible design decision. Thanks. Dmitry. ________________________________ From: Alexander Lisachenko <lisachenko...@gmail.com> Sent: Wednesday, March 30, 2016 15:07 To: Nikita Popov Cc: Dmitry Stogov; Antony Dovgal; PHP internals Subject: Re: [PHP-DEV] Forbid binding methods to incompatible $this Hello, internals! Go! AOP was used closure rebinding to an incompatible context only for one minor specific feature, called privileged advices, where method was executing in the context of target class. But all main closure binding in the framework core work only with compatible contexts, so everything is ok with PHP7 now. So, this new patch is ok for me. Anyway, if I need this functionality again, I can convert methods to the closures via AST transformation of classes. 2016-03-30 14:02 GMT+03:00 Nikita Popov <nikita....@gmail.com<mailto:nikita....@gmail.com>>: On Wed, Mar 30, 2016 at 11:34 AM, Dmitry Stogov <dmi...@zend.com<mailto:dmi...@zend.com>> wrote: > I agree, this ability is a dirty and annoying hack, but I'm sure, some > people use it. > > Tony, you don't use this in the new runkit replacement? :) > > Thanks. Dmitry. > Is this referring to https://github.com/badoo/soft-mocks? If so, searching the codebase for getClosure gives no results, so it shouldn't be affected. I know that the Go! AOP framework used to do some odd things with closure binding on methods. However their use case was *already* completely broken by the limitations we added in 7.0 and the feature was removed. Nikita
