On 16/06/2016 08:18, Pierre Joye wrote: > Hi Dmitry > > I am sorry but I have to ask to wait before merging it. > > It is definitely not clear that: > > . The rfc was valid to begin with due to the short discussion time > . This BC is acceptable for 7.x
As Dmitry pointed out the change has been merged. I had voted yes, and I was prepared to make a few adjustments to the legacy app I work with. You can imagine I was extremely surprised to see that the test suite was green this morning. There might still be some fixing required for the code that isn't covered by tests, but to me this BC-break seems almost irrelevant compared to what we had in 7.0 (e.g. PHP4 constructors or method signatures). Of course I can't speak for the majority of the applications out there, but I think Revive Adserver is a fairly good sample of legacy code one could find. Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
