On Tue, Oct 18, 2016 at 2:35 AM, Sara Golemon <poll...@php.net> wrote:
> As it says on the tin: Wrap the BN (BigNumber) library in OpenSSL. > > https://wiki.php.net/rfc/openssl.bignum > > I don't see any reason why we should expose BN API if it's not integrated with PKEY algorithms. This proposal doesn't really fit with the current functions IMHO so in this case it doesn't make much sense to introduce it unless you would also add classes like OpenSSL\RSA , OpenSSL\EC\Key and so on. I think that having just BigNum in OpenSSL namespace is kind of strange as BN is just a supporting API in for crypto operations in OpenSSL... If it was a functional API, than it would probably fit better with current functions and it would just need to be integrated with openssl_pkey_new which is more achievable and would be a bit more consistent. Cheers Jakub