Hi Adam, On 15/05/2017 09:47, Adam Baratz wrote: > I had a request on the PR[1] to rename the const, from PDO::PARAM_FLT to > PDO::PARAM_FLOAT. Agree that readability is better here. Since there's been > a change, I'll plan on opening the vote tomorrow.
Are you kidding me? You can't possibly think that changing the constant name resets the cooldown counter. You also said: > Based on previous feedback, I thought the new version was materially > different. But if a handful of voters from the last round respond and say > that these changes won't change their vote, then sure, there's no point in > rerunning this. You can count Marco and myself as a handful. I see no one else active on internals saying "yes please". You insist this change will make wonders but it doesn't. MS SQL apparently can't use indexes if you pass the float as strings, while most other databses have evolved since the 2000s and now can. You could quite easily work around it by embedding your floats in the SQL command string instead. Which is basically what emulated prepares would do for you. On the other hand I am still convinced that the new type could potentially cause more issues for anyone else not using pdo_dblib. Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
