Hey: On Thu, Jun 22, 2017 at 3:29 PM, Dmitry Stogov <dmi...@zend.com> wrote:
> hi, > > > could you, please, review the PR https://github.com/php/php-src/pull/2591 > > > The main idea is not to free request-allocated zvals, because they are > freed by Zend MM anyway. > > Also, shutdown_executor() code was simplified by calling destructors and > closing resources, before freeing data. > > > all tests are passed. > I don't see any problems, (just one concern, fast_shutdown is only enable in non-debug mode, which may cause troubles for debuging fast_shutdown problems, maybe we could change it to : fast_shutdown = #if ZEND_DEBUG !report_memleaks && #endif is_zend_mm && !full_table_clean; ), anyway, this feature is already exists in opcache for quite a long time, so I think could commit it. thanks > > Thanks. Dmitry. > -- Xinchen Hui @Laruence http://www.laruence.com/
