Le 06/10/2017 à 21:59, Rasmus Lerdorf a écrit :
> On Fri, Oct 6, 2017 at 12:04 PM, Sara Golemon <poll...@php.net> wrote:
> 
>> On Fri, Oct 6, 2017 at 10:18 AM, Rasmus Lerdorf <ras...@lerdorf.com>
>> wrote:
>>> Sara/Remi do you mind if I merge this into 7.2? This affects opcache
>> debug
>>> output only and I want to start playing with some DCE reporting from
>> Phan.
>>> Having the original line numbers available will make that more effective.
>>>
>>> http://git.php.net/?p=php-src.git;a=commitdiff;h=
>> 9fe6b29356923c23fadf610a9fa421cff8b06d6d
>>>
>> Literally two low-risk lines of actual change to a debug-only path?
>> Zero objections from me.
> 
> 
> Correct, the zend_dump_op() call I tweaked is only ever called if
> opcache.debug_level is set. The bulk of the patch is to add the resulting
> line numbers to the tests that use this debug info to verify the output
> from the optimizer.
> 
> -Rasmus
> 

I'm late, as already applied in 7.2, but of course, this is ok for me.


Remi


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to