Good enough for me. Thanks! On Mon, Nov 20, 2017 at 2:13 AM, Dmitry Stogov <dmi...@zend.com> wrote: > I think PHP 7.2 is a good place for these minor break. > > > Dmitry. > > ________________________________ > From: Sara Golemon <p...@golemon.com> > Sent: Saturday, November 18, 2017 12:17:24 PM > To: Dmitry Stogov; internals@lists.php.net > Subject: Minor BC break in gettype() > > https://3v4l.org/kRON7 > > https://github.com/php/php-src/commit/f00d1c72b4dbaf3532569d20efc1da7c408605d6 > > The above patch optimizes calls to gettype() into an opcode, however the > strings returned for closed resources has changed relative to 7.1 and > earlier. > > The newer output is objectively better, but it's technically a BC break. > > Was this intentional, and are we fine letting this change stand? > > -Sara
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
