Den tir. 4. sep. 2018 kl. 12.20 skrev Christoph M. Becker <cmbecke...@gmx.de>: > That appears to be sensible. Anyhow, *if* we do this, we also should > move the MD5, SHA1 and CRC32 code from ext/standard to ext/hash (MD5 and > SHA1 is currently dead code in ext/hash, and the CRC32 implementation > seems to be duplicated). We should also have a look at crypt_sha256.c > and crypt_sha512.c (of ext/standard) which likely duplicate some code > already available in ext/hash.
Those makes a lot of sense to do, and definitely something we should if this RFC passes -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
