On Fri, Nov 2, 2018 at 8:30 PM Sammy Kaye Powers <m...@sammyk.me> wrote:
> Hey internals! > > Given there has been at least two weeks of discussion around the RFC, > "Improve openssl_random_pseudo_bytes()" and there doesn't seem to be > any outstanding issues, I have moved the RFC into voting phase. > > The voting period lasts two weeks; from now until 2018-11-16. > > The RFC can be found here: > https://wiki.php.net/rfc/improve-openssl-random-pseudo-bytes > > Happy voting! :) I've voted against the deprecation of the $crypto_strong param. IMHO we should just document that it is guaranteed to always be true if the call succeeds and checking it is not necessary. But we should not penalize existing code that is checking the flag -- it may no longer necessary nowadays, but previously that was the correct use of the function. Nikita
