On Sun, Dec 2, 2018 at 10:50 PM Christoph M. Becker <cmbecke...@gmx.de> wrote:
> On 02.12.2018 at 21:24, Jakub Zelenka wrote: > > > I was wondering if we have got a final list of the top features that will > > be listed in the announcement for the stable release. > > > > Not sure how it's usually selected but thought that it would be good to > > list FPM logging changes that I have been working on and it's the main > > improvement in FPM [1]. It's not probably that interesting for PHP devs > but > > it might be quite importants for DevOps who use FPM with Docker and want > to > > properly collect logs from containers. My current client will be updating > > to 7.3 pretty soon just because of that. > > > > [1] https://github.com/php/php-src/pull/2458 > > Thanks for bringing this up, Jakub! To be honest, I haven't really > thought about the release announcement before, so this is a fine reminder. > > Regarding the FPM logging changes: indeed, this seems to be quite an > improvement! :) However, it seems there is no note in UPGRADING (which > is important for the migration guide in the manual) yet. Could you > please add the missing note? > > That's a good point! Just added some extra info to the UPGRADING! I guess the release note about these changes should be a bit shorter. Maybe something like (feel free to edit it :) ): Improved FPM logging with options to remove output decorations and extending limit on number of characters in the logged message. Cheers Jakub