Hi Levi,
It looks like the patch broke something related to opcache. It crashes at least on Wordpress and Drupal. The backtrace https://gist.github.com/dstogov/a2305381a5c9982cceca9e4e252d26c7 shows use-after-free in opcache (works fine with master). Inability to work with opcache, doesn't allow to check the performance impact. It also broke few tests. Some crash. Some produce different warning/errors. $ make test TESTS="Zend tests" ... ===================================================================== FAILED TEST SUMMARY --------------------------------------------------------------------- ZE2 ArrayAccess and ArrayAccessReferenceProxy with references to main array [tests/classes/array_access_011.phpt] Bug #21478 (Zend/zend_alloc.c :: shutdown_memory_manager produces segfault) [Zend/tests/bug21478.phpt] Generator methods can yield by reference [Zend/tests/generators/generator_method_by_ref.phpt] Testing to implement Serializable interface by traits [Zend/tests/traits/interface_003.phpt] Handling of public fields with traits needs to have same semantics as with normal inheritance, however, we do add strict warnings since it is easier to run into something unexpeted with changing traits. [Zend/tests/traits/property009.phpt] iterable type#004 - Parameter covariance [Zend/tests/type_declarations/iterable_004.phpt] iterable type#005 - Return type covariance [Zend/tests/type_declarations/iterable_005.phpt] ===================================================================== I'll try to play with patch and make a full code review on next week. It would be great, if you fix opcache compatibility. If it can't be done in reasonable time, it's probably better to cancel voting and restart when ready. Thanks. Dmitry. ________________________________ From: Dmitry Stogov <dmi...@zend.com> Sent: Thursday, December 20, 2018 6:26:10 PM To: Levi Morrison; internals Subject: Re: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters Hi Levi, Please, create a Pull Request, to keep inline comments on github. Thanks. Dmitry. ________________________________ From: Levi Morrison <le...@php.net> Sent: Thursday, December 20, 2018 2:10:57 AM To: internals Subject: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters Thank you for the feedback and discussion on the [Covariant Returns and Contravariant Parameters RFC][1]. I have opened [voting on this RFC][2]. Given that this is a common time for holidays for many people around the world it will be open until at least January 2nd. Happy holidays! [1]: https://wiki.php.net/rfc/covariant-returns-and-contravariant-parameters [2]: https://wiki.php.net/rfc/covariant-returns-and-contravariant-parameters#voting -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
