Den 2019-04-24 kl. 23:38, skrev Peter Kokot:
Hello,
On Wed, 24 Apr 2019 at 23:12, Björn Larsson <bjorn.x.lars...@telia.com> wrote:
Hi,
I did a quick check on two open source libraries that I'm using,
namely Smarty templating library and Revive ad server. A quick
glance at hand shows that they both uses the <? tag in their
latest release. Smarty 3.1.33 was released 17/9 2018 and
Revive 4.2.0 was released 23/4 2019.
It would be interesting to see if there is any benefit in fixing this
feature for these two well-established libraries? I think that both
these libraries will adapt, but how long will it take... Regarding
your points above I don't see any added value that this feature
brings for me as a user of these two libraries, since I'm quite
happy with the functionality they provide as is. How then the
developers see it is not up to me to judge.
r//Björn L
I'm not sure if we're looking at the same libraries and versions here
but both of these use normal opening tags in the code for quite a
while:
https://github.com/revive-adserver/revive-adserver
https://github.com/smarty-php/smarty
Keywords open source, PHP, and short opening tags don't go together
anymore neither people coding in PHP are using these anymore for a
very long time. If they postpone upgrades and neglect good coding
practices, nothing can help them improve or fix their apps.
Well, checking a bit closer when running the script:
grep -rin "<?[^pxi=]" . | grep ".php" on the source trees I got 13 hits.
None
seems to be critical though. 5 in the Revive case comes from including an
old Smarty 2.6.18 version from 2005.
r//Björn L
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
