On Fri, Oct 11, 2019 at 5:13 PM Marcio Almada <marcio.w...@gmail.com> wrote:
> Hi! > > > > I don't believe atexit applies to os._exit(). In any case, I agree that > > > this is something we're currently missing -- we should probably add a > > > pcntl_exit() for this purpose. It should be noted though that this is > > > really very different from exit(), which is still quite graceful and > usable > > > in a webserver context, while a hypothetical pcntl_exit() would bring > down > > > the server process. As the Python docs mention, the primary use-case > would > > > be exiting from forked processes without going through shutdown, which > has > > > also recently come up in https://github.com/php/php-src/pull/4712. > > > > > > > > >> If we bind `exit()` and `die()` to a catchable exception how would we > > >> still have the scenario 2 available > > >> on PHP land without a BCB? :) > > >> > > > > > >> I have one simple suggestion: Introduce `EngineShutdown -> Throwable`, > > >> bind `exit|die` to it but disallow > > >> `catch(\EngineShutdown $e)` at compile time. This would allow keeping > > >> backwards compatibility to > > >> scenario 2 without messing with our current exception hierarchy. > > >> > > > > > > I think the options are basically: > > > > > > 1. Making EngineShutdown implement Throwable, which would make existing > > > catch(Throwable) catch it -- probably a no-go. > > > > > > 2. Making EngineShutdown not implement Throwable, which means that not > all > > > "exceptions" implement the interface, which is rather odd. It still > allows > > > explicitly catching the exit. > > > > > > 3. Introducing a function like catch_exit(function() { ... }). This > would > > > still allow catching exits (for phpunit + daemon use cases), but the > fact > > > that this is actually implemented based on an exception would be > hidden and > > > the only way to catch the exit is through this function. > > > > > > 4. Don't allow catching exits at all. In this case the exception is > just an > > > implementation detail. > > > > > > Nikita > > > > +1 for option 3. > > So maybe it narrows down to: > > Is there an essencial attempt to improve `exit()` handling from the > userland perspective or should the focus be solely on solving the > memory management issue pointed out in the beginning of the thread? > > If the scope is to also improve userland, option 3 could be the way to > go indeed but I confess to do not be a fan of another callback > registering thing... it feels hard to predict when you consider: > > ``` > catch_exit(function(){ > exit(); // what happens here? We still have to guarantee `exit` to > halt at some point. > }); > ``` > > And what are the interactions with `register_shutdown_function`? I > suppose the `catch_exit` stack has to be run before the > `register_shutdown_function` stack? Considering the behavior in the > docs. > I think I was a bit unclear in how the catch_exit() function is intended to work: It's not an atexit handler, it's basically a try/catch block for exits. $exitExceptionOrNull = catch_exit(function() { // Run code that may contain exit() here }); or possibly even more explicitly as: catch_exit(function() { // Run code that may contain exit() here }, function($exitCode, $exitMessage) { // This is called if an exit() occurred }); I like option 4 much more for now. It allows tackling the root issue > and still leaves possibilities open regarding how the exception > hierarchy could be and how the handling of `exit` could happen > (through a catch at userspace or callback registering). > I guess we should do that as the first step in any case ... everything else would be extensions on top of that, but this would be the main technical groundwork. Nikita > > > > EngineShutdown could be a special exception to the engine, being handled > like an exception internally, but not implement Throwable and therefore not > an exception from user-land's point-of-view. > > > > EngineShutdown could be added to the list of "throwables", but forbid > instigation in user-land. > > > https://github.com/php/php-src/blob/db233501ff9d56765ef4a870b777a643c2136711/Zend/zend_exceptions.c#L909-L916 > > > > No catch block would catch it, because it wouldn't implement Throwable > nor extend Exception or Error. > > > > Very elegant solution! > > PS: Naming things is hard, but `Throwable` could not have been a > better choice in retrospect. Ty ;) > > > Aaron Piotrowski > > > > Márcio >
